This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
Check in public for matching webpackShims #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also simlify the webpackShim checking a bit by using reduce
spalger
reviewed
May 31, 2017
index.js
Outdated
| const baseSource = sourceParts.pop(); | ||
|
|
||
| const pluginShimPaths = [ | ||
| path.join(rootPath, 'webpackShims', ...sourceParts), |
There was a problem hiding this comment.
The webpackShims directory could be in any directory relative to the file up to the root, so this needs to check for webpackShims directories starting at the basedir of the requested file up to the root. The console plugin, for instance, has it's own webpackShims directory, and any directory can have a webpackShims directory just like it can have a node_modules directory.
There was a problem hiding this comment.
The webpackShims directory could be in any directory relative to the file up to the root
I did not know that. That makes resolution a bit trickier. I'm betting there code in Kibana that we can borrow here for the resolution. In any event, this PR will need to be updated then.
check for a matching webpackShims path, starting at the plugin root, walk all the way to the requesting file, then check kibana's root
|
Superseded by #15 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13
Check for a matching
webpackShimspath, starting at the plugin root, walk all the way to the requesting file, then check Kibana's root. Stops as soon as it finds a match, so in most cases, only the first condition is needed.